[DRAFT] Change parameter names of builder methods for domain, version, outputs #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
approved these changes
Jul 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
=======================================
Coverage 75.05% 75.06%
=======================================
Files 245 245
Lines 26437 26437
Branches 4822 4822
=======================================
+ Hits 19842 19844 +2
+ Misses 5663 5662 -1
+ Partials 932 931 -1 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ±0 24 suites ±0 3h 31m 43s ⏱️ + 14m 2s For more details on these failures, see this check. Results for commit c423795. ± Comparison against base commit efe674d. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously. Use parameter names _domain, _version, and _outputs for special kwargs in onnx op builder method.